Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETH support in MultiplexFeature #89

Closed
dekz opened this issue Jul 12, 2021 · 0 comments
Closed

ETH support in MultiplexFeature #89

dekz opened this issue Jul 12, 2021 · 0 comments
Labels
status: implemented Proposed changes have been implemented (and deployed, if smart contract) type: core

Comments

@dekz
Copy link
Member

dekz commented Jul 12, 2021

Summary

This ZEIP adds various improvements to MultiplexFeature, most notably the ability to wrap/unwrap ETH as a convenience to the user. This reduces the cost of ETH-based trading for users in certain execution flows.

Type:

CORE

Motivation

MultiplexFeature is designed to execute gas-efficient swaps for a subset of the sources supported by Transfomers. In particular, MultiplexFeature significantly reduces the gas costs of consuming 0x RFQ liquidity while maintaining safeguards against reverts. Version 1 of the feature did not include the ability to wrap/unwrap ETH, so users buying/selling ETH would not realize these gas savings of the Multiplex execution path.

Multiplex Version 2 adds support for ETH buys/sells, as well as a number of smaller changes that are described in the PR.

Specification

0xProject/protocol#263

Implementation

This proposal would update the Multiplex feature to the latest version. The 0x V4 architecture allows features to be added and upgraded. No change is required for most integrators; certain smart contract integrations may need to update to accommodate the new function signatures introduced by Multiplex V2.

Designated team: 0x Labs

Notes

The change has been spot-checked by Consensys Diligence

@moodlezoup moodlezoup changed the title ETH support in MultiPlex ETH support in MultiplexFeature Jul 12, 2021
@mintcloud mintcloud added the status: implemented Proposed changes have been implemented (and deployed, if smart contract) label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: implemented Proposed changes have been implemented (and deployed, if smart contract) type: core
Projects
None yet
Development

No branches or pull requests

2 participants