Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize on a rustc version #13

Open
8573 opened this issue Jul 28, 2017 · 6 comments
Open

Stabilize on a rustc version #13

8573 opened this issue Jul 28, 2017 · 6 comments
Labels
C-enhancement Category: Tickets requesting changes other than bug-fixes E-easy Difficulty: Low P-medium Importance: Medium
Milestone

Comments

@8573
Copy link
Owner

8573 commented Jul 28, 2017

At some point, explicitly choose a minimum rustc version with which
this library must be built. After so choosing, I could still use newer
rustc features, but only gated behind cfg flags.

To generate the proper cfg flags, see:

@8573
Copy link
Owner Author

8573 commented Jan 15, 2018

I've chosen rustc 1.22.1, the last release of 2017, as the minimum rustc version for the foreseeable future.

(Edit, 2018-09-01 UTC: I would think it irresponsible to support anything older than 1.22.)

Now I just need to document this.

@8573
Copy link
Owner Author

8573 commented Mar 19, 2018

To escape a jobserver bug that was rendering me incapable of running cargo publish (see also: rust-lang/rust#46981), I'm upgrading to rustc 1.24.1 in commit 3bcb5e4.

@8573
Copy link
Owner Author

8573 commented May 25, 2018

And now I'm upgrading to rustc 1.26.0, in commit 1d8d6ad.

@8573
Copy link
Owner Author

8573 commented Jun 18, 2018

For bug fixes, I'm upgrading to rustc 1.26.2, in commit eeb3b1f.

@8573 8573 added C-enhancement Category: Tickets requesting changes other than bug-fixes E-easy Difficulty: Low labels Aug 30, 2018
@8573 8573 added this to the v1.0.0 milestone Aug 30, 2018
@8573 8573 added the P-medium Importance: Medium label Aug 30, 2018
@8573
Copy link
Owner Author

8573 commented Sep 26, 2018

I likely will upgrade to Rust 1.29.1, for the security fix, with that becoming a general rule: a security fix in the standard library being considered justification for raising the minimum supported Rust version.

Incidentally, I think this also brings me stable Clippy, so that's nice (if it's true).

@8573
Copy link
Owner Author

8573 commented Oct 18, 2018

I have upgraded to Rust 1.29.1, as predicted above, in commit f7ce4a7. This does seem to bring me stable Clippy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Tickets requesting changes other than bug-fixes E-easy Difficulty: Low P-medium Importance: Medium
Projects
None yet
Development

No branches or pull requests

1 participant