Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Provide fish shell completions / Fix commands format in the man page #1425

Open
BuonHobo opened this issue May 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@BuonHobo
Copy link

Is your feature request related to a problem? Please describe.
Distrobox man pages specify commands using the following layout:

distrobox create

              --image/-i:     image to use for the container  default: ${container_image_default}
              --name/-n:      name for the distrobox          default: ${container_name_default}
              --hostname:     hostname for the distrobox      default: <container-name>.$(uname -n)
              --pull/-p:      pull the image even if it exists locally (implies --yes)
              --yes/-Y:       non-interactive, pull images without asking

This is fine for a human, but it causes fish shell to have buggy completions:

❯ distrobox-create --absolutely-disable-root-password-i-am-really-positively-sure 
--absolutely-disable-root-password-i-am-really-positively-sure  (COMPATIBILITY for a list of compatible images and container managers, please …)
--additional-flags/-a                                                                                                                           
--additional-packages/-ap                                                                                                                       
--clone/-c                                                                  (this will be useful to either rename an existing distrobox or hav…)
--compatibility/-C                                                                                                                              
--dry-run/-d                                                                                                                                    
--help/-h                                                                                                                                       
--home/-H                                                                                                                                       
--hostname                                                                                                                                      
--image/-i                                                                                                                                      
--init/-I                                                                   (this will make host[aq]s processes not visible from within the co…)
--init-hooks                                                                                                                                    
--name/-n                                                                                                                                       
--no-entry                                                                                                                                      
--nvidia                                                                                                                                        
--pre-init-hooks                                                                                                                                
--pull/-p                                                                                                                                       
--root/-r                                                                   (way over [dq]sudo distrobox[dq] (note: if using a program other t…)

As you can see, the completion are in the format --longcommand/-shortcommand and if you complete your prompt using TAB then the completion will not work. You have to manually go and delete the last part

Describe the solution you'd like
I'd like the distrobox man page to list commands in the man page in the classic format, or at least I'd like for it to provide correct fish shell completions which is all I really care about.

@BuonHobo BuonHobo added the enhancement New feature or request label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant