Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS - configurable Access-Control-Allow-Headers #101

Closed
artlogic opened this issue Oct 29, 2015 · 3 comments
Closed

CORS - configurable Access-Control-Allow-Headers #101

artlogic opened this issue Oct 29, 2015 · 3 comments

Comments

@artlogic
Copy link
Contributor

Since drakov enforces specified request headers (like Authorization), it would be helpful if either CORS headers could be configured (via a --header argument) or auto-configured. Right now I'm manually patching lib/middleware/response.js to allow the Authorization header.

I'd be willing to provide a pull request to add in a --header argument if it would be accepted.

@yakovkhalinsky
Copy link
Contributor

Hey @artlogic was something we had look at putting on our roadmap.

At some point I am thinking I would like to possibly remove or consolidate switches/configuration options that cause header changes in the response for the next minor version update (0.2.0), but for a patch version (0.1.x) I think this would be super useful 👍

@artlogic
Copy link
Contributor Author

artlogic commented Dec 2, 2015

I've submitted a pull request. Let me know if I can do anything else to get this out as a patch to v0.1.

@artlogic
Copy link
Contributor Author

artlogic commented Dec 2, 2015

Closed via 7fea735

@artlogic artlogic closed this as completed Dec 2, 2015
@yakovkhalinsky yakovkhalinsky added this to the 0.1.17 release milestone Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants