Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to filter at AdGuard service start-up #4454

Closed
Morku opened this issue Oct 25, 2022 · 11 comments
Closed

Add the option to filter at AdGuard service start-up #4454

Morku opened this issue Oct 25, 2022 · 11 comments

Comments

@Morku
Copy link

Morku commented Oct 25, 2022

After updating AdGuard to version 7.11 I had to find out after reboot, that AdGuard is no more active anymore.

I did uncheck "Launch AdGuard at system start-up" all the version back to disable to the tray icon for a clean UI experience. When I updated to 7.11, there was no warning that AG will be disabled entirely at next system restart.

Now I have to check "Launch AdGuard at system start-up" back on to be protected again directly after boot and need to "Close AdGuard, but continue filtering" everytime I booted my system.

I really hope this update won't be pushed out automatically, because I configured all my family member systems this way so that they don't have to bother with the program in the tray icon. If they receive the update, all systems will be unprotected now and many members live remotely. This is some worse case scenario for me.

So, please bring back silent start of AG when OS boots and/or check the option "Launch AdGuard at system start-up" when AdGuard gets updated, so that no functionallity for AdGuard get's degraded after update.

@maxikuzmin
Copy link

@Morku did I understand correctly that you didn't have AdGuard autorun after the upgrade, even though you had autorun set up on the previous version? What version did you have before the upgrade?

@Morku
Copy link
Author

Morku commented Oct 31, 2022

@maxikuzmin

You changed the behaviour of the setting "Launch AdGuard at system start-up", see:

All my systems, installed with AdGuard are configured with unchecked "Launch AdGuard at system start-up" to have the original behavious of the setting. Means: When you boot your computer there is no AdGuard icon in task symbol row, but ads are filtered anyway, so AdGuard ist running completely in background without being visible.

Since the setting is now changed, imagine the following:
You have unchecked the option to have AdGuard running in background. Now you get the AdGuard 7.11 update. The setting is still unchecked after the update.
Now you restart your computer and suddenly no Ads are filtereds anymore, because the behavious changed to not run AdGuard at all in background. Now you need to start AdGuard first to get filtering back (and hide it from task icons).
If you are unaware to use AdGuard, because someone maintain your system (like I do), the person get worried.

With the change of the setting, you are forced to set "Launch AdGuard at system start-up" to be protected after system start. But you will also have the icon in task symbol.

I do see the reason why you changed it, because the option implies not to start AdGuard at boot at all, but I prefer to had only the description changed, like: "Launch AdGuard task symbol at system start-up". Or to have the choice of both.

@maxikuzmin
Copy link

@Morku I tried upgrading from 7.10.2 to 7.11 versions, but I don't have this problem. What version did you upgrade from?

@Morku
Copy link
Author

Morku commented Nov 1, 2022

@maxikuzmin
The same version like you. From version 7.10.2 to 7.11.

See the following video.

  1. I have version 7.10.2 installed
  2. I have disabled "Launch AdGuard at system start-up". (to get rid of the task icon)
  3. I reboot. No AdGuard symbol is loaded in task symbols (as expected) and filtering test is fine
  4. I update to 7.11
  5. I reboot
  6. AdGuard is now completely disabled, without any warning. The test page fails.
  7. I have to start AdGuard manually to get filtering back, but also brings back the unwanted task icon
  8. -> I have to enable back "Launch AdGuard at system start-up" what also brings back the unwanted task icon
2022-11-01_16-58-50.mp4

EDIT: Reuploaded video. In original video, no taskbar (with task icons) was visible. Cut to much of bottom of video before.

@maxikuzmin
Copy link

@Morku however, I don't have that problem.
To troubleshoot this issue, we need to get the app logs.

Here's what we need you to do:

  • Collect the debug log as it's explained here.
  • Remember the exact time when the issue was reproduced. We will need it to find the corresponding records in the log file.
  • Send the archive to devteam@adguard.com and mention this issue number in the subject.

@Morku
Copy link
Author

Morku commented Nov 2, 2022

@maxikuzmin
I have send an Email with the attached Debug Log.

16:41 -> AdGuard 7.10.2 installed, Debug Logs enabled and unchecked "Launch AdGuard at system start up", filtering fine on AG test page
16:42 -> Rebooted
16:42 -> still filtering fine
16:44 -> AdGuard started -> Updated to AdGuard 7.11 -> Rebooted
16:46 -> filtering fails on AG test page. AdGuard is not running in background anymore to filtering, but service is running regarding task-manager
16:47 -> started AdGuard and exported Debug Log

(16 = 4pm)

@Kobi-Blade
Copy link

Kobi-Blade commented Nov 7, 2022

I can easily replicate this issue on all computers at my household, AdguardSvc.exe is running on the background on start-up but is not blocking any ads.

Adguard only starts working after I launch Adguard.exe, as OP stated, in my opinion this is a huge regression and has been getting in the way of my daily workflow.

And seems from OP evidence it is caused by unneeded enhancement that just broke functionality, #2489

AdguardSvc.exe running on start-up without the UI, while blocking ads, was a feature! The irony that a commit marked feature, actually removed a feature!

I apologize in advance if I sound rude, but I been fighting with this problem ever since 7.11 with no answer from the development team (besides redirecting me to 7.11.1 hotfix that didn't fix my issue) and I finally found the issue! And despite being a major feature for me, I'll have to wait until 7.12, so I'm extremely frustrated right now.

I rolled back to 7.10.2 and blocked updates until this issue is fixed, thank you for bringing this up Morku.

@snhv
Copy link

snhv commented Nov 17, 2022

Just want to say that I have this problem too. How it will get fixed soon.

@zubrRB
Copy link

zubrRB commented Nov 17, 2022

В идеале было бы хорошо, чтобы:

  1. Запускались фильтрация и UI (что сейчас по умолчанию).
  2. Можно было отключить загрузку UI, оставив только фильтрацию.
  3. Можно было полностью отключить (с выгрузкой процессов) фильтрацию и UI.

@snhv
Copy link

snhv commented Nov 17, 2022

В идеале было бы хорошо, чтобы:

1. Запускались фильтрация и UI (что сейчас по умолчанию).

2. Можно было отключить загрузку UI, оставив только фильтрацию.

3. Можно было полностью отключить (с выгрузкой процессов) фильтрацию и UI.

Re #2, not just filter but also update (the rules and the program) too.

@Kobi-Blade
Copy link

Just want to say that I have this problem too. How it will get fixed soon.

It won't, best option is to roll back to 7.10.2 and block upgrades, cause they gave this issue low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants