Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow *## cosmetic rules #1437

Closed
ameshkov opened this issue Apr 11, 2021 · 0 comments
Closed

Allow *## cosmetic rules #1437

ameshkov opened this issue Apr 11, 2021 · 0 comments
Assignees
@sxgunchenko
Labels
Enhancement P3: Medium Resolution: Fixed Status: Closed Version: CoreLibs v1.8
Milestone
v1.8

Comments

@ameshkov
Copy link
Member

ameshkov commented Apr 11, 2021 •
edited
Loading

Currently, for globally valid rules we just use ## with no domains specified: ###banner

For compatibility purposes I suggest supporting *###banner rules as well (these are pretty much the same).

Note, that it should work the same way with all non-basic rules: #?#, #%#, $$, etc)
@ameshkov ameshkov added this to the v1.8 milestone Apr 11, 2021
This was referenced Apr 11, 2021
Closed
Closed
Yuki2718 referenced this issue in AdguardTeam/AdguardFilters Apr 30, 2021
@Yuki2718
fix https://github.com/hirorpt/filters/commit/4093df5f9af8693617f1774…
fd74b24 
…3491335cb3f057387#commitcomment-50205797 - FP/filter doesn't work on uBO
@sfionov sfionov mentioned this issue Jul 1, 2021
Closed
@ameshkov ameshkov mentioned this issue Jul 1, 2021
Closed
@sfionov sfionov mentioned this issue Jul 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sxgunchenko sxgunchenko

Labels
Enhancement P3: Medium Resolution: Fixed Status: Closed Version: CoreLibs v1.8
Projects
None yet
Milestone
v1.8
Development

No branches or pull requests
3 participants
@ameshkov @sxgunchenko @adguard-bot