Do not split rules with many domains in the unless-domain and if-domain

[ameshkov]

~example.org,.....,~example1000.org##banner rule will be split into several rules in the resulting json. This is plain wrong.

Here's what we should do:

1. Check how many domains can in theory be specified in unless-domains
2. Discard rules that have more domains than that.

[Alex-302]

2. Discard rules that have more domains than that.

How will the filters maintainers know about this?

[ameshkov]

The only way would be to have a special check in AGLint for this.

[Alex-302]

Maybe the apps that has problems with such rules should be warned about it - only AdGuard for iOS and Safari?
Other products are not affected by the problem.

[ameshkov]

There are lots of rules that are getting discarded when converting them for Safari, it's not realistic to list them all.

The problem with this particular case is that the problem can be not with a single rule, but with a multitude of #@# rules.

[Alex-302]

it's not realistic to list them all

Can be printed to the log.

[ameshkov]

I actually think we're doing that when debug log is enabled

[Alex-302]

I can't find it

[ameshkov]

Examine com.adguard.AdguardExtension

[Alex-302]

I don't see any rules there.

Why not use the obvious file names? Because of OS limitations?

[ameshkov]

Tbh, no idea:)

[Alex-302]

In any case, only the number of errors is logged, not the details.

[maximtop]

I've tested on macOS 13.4 and Safari 16.5, and it looks like "unless-domain" and "if-domain" support at least 10000 values.
So, we should stop splitting them both.