Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for uBO regexp domain list #89

Open
scripthunter7 opened this issue May 19, 2023 · 3 comments
Open

Support for uBO regexp domain list #89

scripthunter7 opened this issue May 19, 2023 · 3 comments

Comments

@scripthunter7
Copy link
Member

scripthunter7 commented May 19, 2023

uBo implemented regex, if someone trust something like:

/bad-js.$domain=/[a-z-]{18}\.[\w]{2,20}/
/[a-z-]{18}\.[\w]{2,20}/##.bad-class
!
! regex in the dumb version - rather, the webmaster fell how to avoid falling into a safe regex.

but fail for , in cosmetic/scriptlet filters and | in network filters if gorhill rejected repair:

uBlockOrigin/uBlock-issues#2234 (comment)


In theory, network filtering can be unprotected by domain=/from= and cosmetic filtering can be based on the site's permanent DOM tree (No match to 99% of the rest of the sites on the Internet).

The scriptlet is also still possible to run all over the Internet in uBo, but there have been considerations for years whether to secure this with a minimum of "I am an advanced user" activation.


Also voe is covered sometimes: uBlockOrigin/uAssets@5a660a9

(Unfortunately, I don't see how to turn these 36 domains into which regex - The site appears to have no fixed pattern (diffrent words, number order).)

Originally posted by @krystian3w in AdguardTeam/CoreLibs#1550 (comment)

@scripthunter7
Copy link
Member Author

@maximtop We should move this to AGTree

@maximtop
Copy link
Contributor

@maximtop We should move this to AGTree

ok, lets move

@krystian3w
Copy link

Via ZenHub, native "transfer issue" or manually by copy few sentences from here?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants