Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Make Optional the message that gets printed when ignoreSslErrors = true #51

Open
mlfreeman2 opened this issue Mar 11, 2021 · 0 comments

Comments

@mlfreeman2
Copy link

I have a test install running at work and noticed something: even with ignoreSslErrors=true in my config a message is being printed to NLog internal logging.

I figure that if I'm not interested in SSL errors, nothing should be printed to NLog's internal log.

It seems to be coming from this line.

OnError(new HttpEventCollectorException(HttpStatusCode.NotAcceptable, reply: warning));

Perhaps you could refactor this into a warnOnSslErrors boolean as a separate option, or maybe turn the ignore boolean into an enum ("yes", "no", "warn").

@mlfreeman2 mlfreeman2 changed the title Remove message that gets printed when ignoreSslErrors = true Remove/Make Optional the message that gets printed when ignoreSslErrors = true Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants