Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: patch of server check #4

Closed
GitMensch opened this issue Jan 24, 2024 · 3 comments
Closed

TODO: patch of server check #4

GitMensch opened this issue Jan 24, 2024 · 3 comments

Comments

@GitMensch
Copy link

The new script resources/server/bin/helpers/check-requirements-linux.sh will likely need a patch, to ne adjusted for whatever the minimal requirements for this fork are.

Note: what the exact minimal requirements are and how this makes the difference to VSCodium is still missing in https://github.com/Alex313031/codium/blob/master/README.md (which is tracked in #1 and #2 - one of those may need to be reopened):

@Alex313031 wrote:

However, I could update the docs to use the new name and make it clear that this is the (currently) only vscode/vscodium fork to still support win7/8/8.1 or ubuntu 16.04.

This part is very important, as the question comes up again also for Ubuntu 18/RHEL7, as electron dropped support for that (but there are now the experimental glibc-217 node binaries, which may be used as drop-in replacement (also checked for VSCodium see VSCodium#1629)

@Alex313031
Copy link
Owner

@GitMensch This should still work with 18.04. I build and test it in a 18.04 VM.

@GitMensch
Copy link
Author

GitMensch commented Feb 4, 2024

The point is that vscodeserver (used with remote workspace) would likely not work if you don't patch that file - as this raises an error when glibc is considered to be too old.

@Alex313031
Copy link
Owner

@GitMensch They added a patch for this upstream now, and besides, I don't ship the web version, as it doesn't make sense for this fork (which is for running on older OSes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants