Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] StocksEnv not giving any reward when trading with crypto or index data #72

Closed
Olwar opened this issue Jul 27, 2022 · 2 comments

Comments

@Olwar
Copy link

Olwar commented Jul 27, 2022

Hi,

I was battling with this a long time because I couldn't figure our why the env didn't give any reward even after 1 000 000 runs. But apparently StocksEnv doesn't give any reward if you're using data from cryptos or indices (at least S&P 500). Would you say that ForexEnv is the best choice for indices and crypto?

Br,
Olwar

@Olwar
Copy link
Author

Olwar commented Jul 27, 2022

Also another question now that I got the env to give reward.
It seems to give exactly the same reward after the first episode as you can see in my notebook: https://github.com/Olwar/eth-reinforcement/blob/master/eth_reinforcement.ipynb

Is this normal behaviour?

Sorry if these questions are dumb, I'm very new to reinforcement learning.

E: I tested with 100 000 timesteps again and it gives the same reward in every episode.

@AminHP
Copy link
Owner

AminHP commented Jul 30, 2022

  1. Yes, because Crypto is designed similar to Forex pairs. For example in Bitcoin, you can trade with BTC/USD or BTC/ETH pairs.
  2. I'm not sure if it is normal, but the loss value is decreasing. Does it happen with the default dataframes?

@AminHP AminHP closed this as completed Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants