Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logging in json format #110

Open
grzesuav opened this issue Mar 17, 2020 · 2 comments
Open

Enable logging in json format #110

grzesuav opened this issue Mar 17, 2020 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@grzesuav
Copy link
Collaborator

GoogleCloudPlatform/metacontroller#167

@AmitKumarDas AmitKumarDas added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 18, 2020
@AmitKumarDas
Copy link
Owner

What is the end goal in mind here @grzesuav ?
Do we think exposing operational stuff as metrics achieves the same goal?
Since metac can be used as a library, does it mean all those projects should also use json based logging?

@grzesuav
Copy link
Collaborator Author

To make it compatible with elasticsearch or any distributed logging aggregation system.

It should be configurable, I do not have much insights in go ecosystem.

In java world I would :

  • use logging abstraction (like slf4j)
  • separate standalone and library packages - like distribution == library + runtime implementation
    so it allow to have common core and let implementation of used logging library up to user and put some additional layer for distribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants