Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose generic controller annotation keys as public #115

Closed
AmitKumarDas opened this issue Mar 21, 2020 · 2 comments · Fixed by #130
Closed

expose generic controller annotation keys as public #115

AmitKumarDas opened this issue Mar 21, 2020 · 2 comments · Fixed by #130
Assignees
@AmitKumarDas
Labels
good first issue Good for newcomers help wanted Extra attention is needed released

Comments

@AmitKumarDas
Copy link
Owner

AmitKumarDas commented Mar 21, 2020 •
edited
Loading

Expose these constants as PUBLIC to be used by third party libraries or external controllers.

https://github.com/AmitKumarDas/metac/blob/master/controller/common/manage_attachments.go#L37-L41

attachmentCreateAnnotationKey string = "metac.openebs.io/created-due-to-watch"

attachmentUpdateAnnotationKeySuffix string = "/updated-due-to-watch"

lastAppliedAnnotationKeySuffix string = "/gctl-last-applied"
@AmitKumarDas AmitKumarDas added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 21, 2020
@AmitKumarDas
Copy link
Owner Author

I have started working on this!

@AmitKumarDas AmitKumarDas self-assigned this Apr 13, 2020
@AmitKumarDas AmitKumarDas mentioned this issue Apr 14, 2020
Merged
@AmitKumarDas
Copy link
Owner Author

🎉 This issue has been resolved in version 0.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmitKumarDas AmitKumarDas

Labels
good first issue Good for newcomers help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(refactor): make common & dynamic packages readable AmitKumarDas/metac
1 participant
@AmitKumarDas