Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add omitempty json tags against fields of advanced selector #126

Closed
AmitKumarDas opened this issue Apr 12, 2020 · 2 comments · Fixed by #130
Closed

add omitempty json tags against fields of advanced selector #126

AmitKumarDas opened this issue Apr 12, 2020 · 2 comments · Fixed by #130
Assignees
@AmitKumarDas
Labels
api good first issue Good for newcomers help wanted Extra attention is needed released select

Comments

@AmitKumarDas
Copy link
Owner

AmitKumarDas commented Apr 12, 2020 •
edited
Loading

All the fields present in advanced selector are optional. It will be good to omit these null-able field(s) during marshal if they are not set.
@AmitKumarDas AmitKumarDas added api good first issue Good for newcomers help wanted Extra attention is needed select labels Apr 12, 2020
@AmitKumarDas AmitKumarDas self-assigned this Apr 13, 2020
@AmitKumarDas
Copy link
Owner Author

I have started working on this!

@AmitKumarDas AmitKumarDas mentioned this issue Apr 14, 2020
Merged
@AmitKumarDas
Copy link
Owner Author

🎉 This issue has been resolved in version 0.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmitKumarDas AmitKumarDas

Labels
api good first issue Good for newcomers help wanted Extra attention is needed released select
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(refactor): make common & dynamic packages readable AmitKumarDas/metac
1 participant
@AmitKumarDas