Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete logs don't depict the right workflow #77

Closed
AmitKumarDas opened this issue Dec 17, 2019 · 1 comment · Fixed by #84
Closed

Delete logs don't depict the right workflow #77

AmitKumarDas opened this issue Dec 17, 2019 · 1 comment · Fixed by #84
Labels
good first issue Good for newcomers help wanted Extra attention is needed released

Comments

@AmitKumarDas
Copy link
Owner

Problem Statement: Current code of Metac logs for extra delete checks even if the object is not a candidate for delete.

Solution: Move extra delete checks from:

https://github.com/AmitKumarDas/metac/blob/master/controller/common/manage_attachments.go#L552-L572

to

https://github.com/AmitKumarDas/metac/blob/master/controller/common/manage_attachments.go#L574-L577

Above will ensure logs show the right workflow.
@AmitKumarDas AmitKumarDas added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 17, 2019
@PumpkinSeed PumpkinSeed mentioned this issue Dec 22, 2019
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move delete logs
1 participant
@AmitKumarDas