Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logs don't depict the right workflow #78

Closed
AmitKumarDas opened this issue Dec 17, 2019 · 1 comment
Closed

Update logs don't depict the right workflow #78

AmitKumarDas opened this issue Dec 17, 2019 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AmitKumarDas
Copy link
Owner

Problem Statement: Current code of Metac logs the extra update checks even if the object is not a candidate for update.

Solution: Change the log statements present in following blocks of code:

https://github.com/AmitKumarDas/metac/blob/master/controller/common/manage_attachments.go#L299-L352

e.g.

if oObj.GetDeletionTimestamp() != nil && !e.IsUpdateDuringPendingDelete() {
		glog.V(4).Infof(
			"%s: Can't update %s: Pending deletion", e, DescObjectAsKey(dObj),
		)
		return nil
	}

to

if oObj.GetDeletionTimestamp() != nil && !e.IsUpdateDuringPendingDelete() {
		glog.V(4).Infof(
			"%s: Not eligible for update %s: Pending deletion", e, DescObjectAsKey(dObj),
		)
		return nil
	}
@AmitKumarDas AmitKumarDas added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 17, 2019
@AmitKumarDas
Copy link
Owner Author

this has been solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant