Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to add Update similar to UpdateAny but for specific attachment #79

Closed
AmitKumarDas opened this issue Dec 17, 2019 · 1 comment
Closed
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AmitKumarDas
Copy link
Owner

AmitKumarDas commented Dec 17, 2019

Problem Statement: Currently GenericController supports updating any attachment via UpdateAny tunable. However, there can be cases when GenericController should support fine granular update policies on a per attachment basis. In such a case, UpdateAny will not be set and Update will be set against a particular attachment kind.

@AmitKumarDas AmitKumarDas added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 17, 2019
@AmitKumarDas
Copy link
Owner Author

AmitKumarDas commented Dec 17, 2019

Solution: Spec.Attachments[n].UpdateStrategy is by default set to "OnDelete". In other words, update can only proceed if that attachment is first deleted. This property can be made use of to set updates against particular resource kind(s) only even when UpdateAny is set to true. In other words, do not set this property against the attachments if we want to avoid updating that particular attachment. In addition, set other attachment kind(s) to following if we want to update them.

    updateStrategy:
      method: InPlace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant