Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thorin::Node_TypeParam not handled in CodeGen::convert(Type type) #39

Open
richardmembarth opened this issue Jan 23, 2016 · 4 comments
Open

thorin::Node_TypeParam not handled in CodeGen::convert(Type type) #39

richardmembarth opened this issue Jan 23, 2016 · 4 comments
Assignees
@leissa
Milestone
0.5

Comments

@richardmembarth
Copy link
Member

Thorin segfaults since thorin::Node_TypeParam is nod handled in CodeGen::convert(Type type), see commit AnyDSL/impala@93237d5
@richardmembarth richardmembarth added this to the 0.4 milestone Jan 23, 2016
@leissa
Copy link
Member

leissa commented Jan 23, 2016

This cannot work. LLVM does not support polymorphism.

@richardmembarth
Copy link
Member Author

So this needs to be resolved earlier?

@leissa
Copy link
Member

leissa commented Jan 23, 2016

yes, I can write a pass which rewrites all uses of polymorphic "C" externs accordingly. It's not hard.

@leissa leissa modified the milestones: 0.5, 0.4 Jan 26, 2016
@leissa
Copy link
Member

leissa commented Jan 26, 2016

We will solve this issue in the long term via traits / better type system.

NeuralCoder3 pushed a commit to NeuralCoder3/thorin-2-autodiff-legacy that referenced this issue May 17, 2022
@leissa
Merge pull request AnyDSL#39 from fodinabor/restricted-dep-types
db19ff4 
(Re-)add Singleton node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leissa leissa

Labels
None yet
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@richardmembarth @leissa