Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybind to open Wireless Terminal from anywhere in your inventory much easier. #4968

Closed
TheUnderTaker11 opened this issue Feb 4, 2021 · 3 comments · Fixed by #6251
Closed
Labels
good-first-issue Issues that may be good for new contributors

Comments

@TheUnderTaker11
Copy link

Describe the issue

Simply add a keybind to open to Wireless terminal. I'm suggesting this due to the fact that right now I'm playing a modpack, and the only thing swaying me to Refined Storage, even though I love AE much more, is the fact I know I will never be able to keybind it without the "Wireless Crafting Terminal" mod being updated. I'm amazed it's not be added to the base mod by now.

Environment

  • Environment: N/A, this is a suggestion
@yueh
Copy link
Member

yueh commented Feb 15, 2021

When used correctly the wireless terminal is a pretty powerful tool. For now I simply consider that sacrificing a single hotbar slot is an acceptable compromise. Minecraft itself also does not allow you to bind your pickaxe to a hotkey and then stuff it into the player inventory, instead it needs to be on the hotbar to be used.

Additionally AE2 already removes a large part of the inventory management of minecraft, so keeping a bit around as gameplay decision is not that bad.

@yueh yueh closed this as completed Feb 15, 2021
@shartte shartte reopened this Feb 15, 2021
@shartte
Copy link
Member

shartte commented Feb 15, 2021

I actually like this one :-P

(PRs welcome, we're not going to do this ourselves anytime soon)

@yueh
Copy link
Member

yueh commented Feb 15, 2021

Certainly not for the case of just stuffing it somewhere in your inventory, ideally even inside a random bag.

I'd guess a hotkey when it's on the hotbar is fine, but mostly useless. There are also other problems like we currently lock the terminal (and other stuff like portable cells) when being used, so a player cannot accidentally throw them into the network. Or even the portable cell into itself. How we do this is pretty hacky and I am not even sure, if this works for anything but the hotbar.
So it would also be placed on the "can be done once we refactor the GUI stuff" list.

Another option would be to make it a bauble, if that is still a thing. So players would still have to compromise about their ideal setup. So basically anything which falls under "have your cake and eat it" is out.

@Technici4n Technici4n added the good-first-issue Issues that may be good for new contributors label Apr 3, 2022
Technici4n pushed a commit that referenced this issue May 29, 2022
…ble Storage Cells (#6251)

* add keybinds for Wireless (Crafting) Terminal and Portable Storage Cells

* make registering LocatingService via the api possible

* change LocatingServices#register to be last in, first out, so addons can take priority

* spotless

* hotkeys for 256K portable cells

* adapt for network changes

* rename LocatingService -> HotkeyAction
add IDs to API
move wireless crafting terminal hotkey to wireless terminal

* register Hotkeys when the Hotkey actions are registered, and not on static in Hotkeys

* make HotkeyActionsImpl#register synchronized

* replace Locatable with a Predicate<ItemStack>

* move HotkeyAction to api.features and merge it with HotkeyActions
rename HotkeyActionsImpl to HotkeyActions

* try opening more items if the first one fails

* add Keybindings to Localization
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good-first-issue Issues that may be good for new contributors
Projects
None yet
4 participants