Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close wireless terminals and portable cells using the open keybind #7020

Closed
Mari023 opened this issue Apr 4, 2023 · 4 comments · Fixed by #7425
Closed

close wireless terminals and portable cells using the open keybind #7020

Mari023 opened this issue Apr 4, 2023 · 4 comments · Fixed by #7425
Labels
good-first-issue Issues that may be good for new contributors

Comments

@Mari023
Copy link
Contributor

Mari023 commented Apr 4, 2023

Describe the feature

pressing the open terminal keybind while the terminal is open should close the terminal again
(same with portable cells)

Reasons why it should be considered

mostly for consistency, since the vanilla inventory can also be closed by using the inventory key

Additional details

originally opened on ae2wtlib: Mari023/AE2WirelessTerminalLibrary#194
@Technici4n
Copy link
Member

for wireless terminals specifically, right?

@Technici4n Technici4n added the good-first-issue Issues that may be good for new contributors label Apr 5, 2023
@Mari023
Copy link
Contributor Author

Mari023 commented Apr 5, 2023

yes, wireless terminals and portable cells only

@Technici4n Technici4n changed the title close terminals using the open keybind close wireless terminals and portable cells using the open keybind Apr 5, 2023
@floridaman
Copy link
Contributor

Socializing a potential way of adding this feature.

#7182

@shartte shartte mentioned this issue Jun 4, 2023
Closed
@shartte
Copy link
Member

shartte commented Jun 4, 2023

This may conflict hard with tab focus behavior if one uses the TAB keybind.

@floridaman floridaman mentioned this issue Jun 4, 2023
Closed
@Mari023 Mari023 mentioned this issue Oct 1, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good-first-issue Issues that may be good for new contributors
Projects
None yet
Milestone
No milestone
4 participants
@shartte @floridaman @Technici4n @Mari023