Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while dragging fluid from EMI to Interface #7956

Closed
MuteTiefling opened this issue Jun 22, 2024 · 5 comments · Fixed by #7960
Closed

Crash while dragging fluid from EMI to Interface #7956

MuteTiefling opened this issue Jun 22, 2024 · 5 comments · Fixed by #7960
Labels
bug Self explanatory?

Comments

@MuteTiefling
Copy link

Describe the bug

Game crashes while dragging fluid from EMI to Interface

How to reproduce the bug

Drag a fluid from EMI to Interface

Expected behavior

No crash

Additional details

No response

Which minecraft version are you using?

1.21

On which mod loaders does it happen?

NeoForge

Crash log

https://gist.github.com/MuteTiefling/8d75ce7c021a9355a65bd5c6d93a3696

@MuteTiefling MuteTiefling added the bug Self explanatory? label Jun 22, 2024
@MuteTiefling
Copy link
Author

Seems related, so I'm just adding it here: https://gist.github.com/MuteTiefling/8d619430c130527d8bed014714f80ab4

This crash happened while attempting to set a pattern that includes water. Happened as I moused over the recipe tab in EMI

@Mithi83
Copy link
Contributor

Mithi83 commented Jun 22, 2024

EmiFluidStackConverter.java has an explicit throw and a TODO comment in there

    @Override
    public @Nullable GenericStack toGenericStack(EmiStack stack) {
        var fluid = stack.getKeyOfType(Fluid.class);
        if (fluid != null && fluid != Fluids.EMPTY) {
            // TODO 1.20.5
            throw new UnsupportedOperationException();
//            var fluidKey = AEFluidKey.of(fluid, stack.getNbt());
//            return new GenericStack(fluidKey, stack.getAmount());
        }
        return null;
    }

This would probably affect every interaction with EMI involving fluids.

@MuteTiefling
Copy link
Author

Alright. They seem to believe it's something on ae2's end (see linked issue)

@shartte
Copy link
Member

shartte commented Jun 23, 2024

Oopsi :D

@shartte
Copy link
Member

shartte commented Jun 23, 2024

I tell y'all, no one fucking used the 1.20.5/1.20.6 versions. I have to go back and check all those porting comments.

Working on this one immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Self explanatory?
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants