Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player inventory in Export Bus is Misaligned #7963

Closed
shartte opened this issue Jun 23, 2024 · 3 comments · Fixed by #7989
Closed

Player inventory in Export Bus is Misaligned #7963

shartte opened this issue Jun 23, 2024 · 3 comments · Fixed by #7989

Comments

@shartte
Copy link
Member

shartte commented Jun 23, 2024

image

@Mithi83
Copy link
Contributor

Mithi83 commented Jun 26, 2024

I‘m currently out of town and not near any development setup, but a bit of digging around in the source showed some inconsistencies that could be relevant here:

src/main/resources/assets/ae2/screens/io_bus.json uses

  "background": {
    "texture": "guis/storagebus.png",
    "srcRect": [0, 0, 176, 251]
  },

As opposed to storage_bus.json itself which has

  "background": {
    "texture": "guis/storagebus.png",
    "srcRect": [0, 0, 176, 253]
  },

Notice the difference by 2 in the last number. My guess would be to a) verify that storagebus GUI is ok and b) copy over the number from storagebus.json would fix the problem. Bonus points for anyone willing to search for storagebus.png in other jsons and see if any other places are inconsistent.
I‘d do it myself, but that‘ll have to wait till next week.

@shartte
Copy link
Member Author

shartte commented Jun 26, 2024

Same one happens in one of the planes apparently.

@Mithi83
Copy link
Contributor

Mithi83 commented Jun 26, 2024

formation_plane.json (251), storage_bus.json (253), io_bus.json (251). Git blame shows that storage_bus.json was updated during Rid’s retexturing, the other two were not and must be changed to 253 as well. Tested on an old laptop which took ages to set up the repo. I can‘t prepare a PR from abroad though.

Mithi83 added a commit to Mithi83/Applied-Energistics-2 that referenced this issue Jun 30, 2024
Fixes AppliedEnergistics#7963.

All three use the storagebus.png but differ in the srcRect size. While
storage_bus.json was updated during retexturing, the others were not
leading to:
  - misaligned player inventory
  - missing a 2 pixel wide bottom border area
shartte pushed a commit that referenced this issue Jun 30, 2024
Fixes #7963.

All three use the storagebus.png but differ in the srcRect size. While
storage_bus.json was updated during retexturing, the others were not
leading to:
  - misaligned player inventory
  - missing a 2 pixel wide bottom border area
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants