Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepLinkDelegate not working properly #156

Open
ko7tya opened this issue Feb 2, 2021 · 7 comments
Open

DeepLinkDelegate not working properly #156

ko7tya opened this issue Feb 2, 2021 · 7 comments

Comments

@ko7tya
Copy link

ko7tya commented Feb 2, 2021

Report

DeepLinkDelegate doesn't return any information after user open app via deeplink

SDK Version

6.1.4

What did you do?

Install via Swift Package Manager

What did you expect to happen?

didResolveDeepLink should return information regarding from OneLink deeplink, after the user tap on it and the app opens

What happened instead?

After app opens from deeplink, system event:
func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([UIUserActivityRestoring]?) -> Void) { AppsFlyerLib.shared().continue(userActivity, restorationHandler: nil) } is called and we pass data to AppsFlyerLib with regarding method, but we didn't receive any information from AppsFlyerLib after that

Please provide any other relevant information.

There are 3 cases that we tested regarding OneLink deepLinks:

  1. User doesn't have installed app:
  • User taps on deeplink:
  • It sends the user to AppStore
  • User download the app and open it
  • All information regarding deeplink is coming from func onConversionDataSuccess(_ conversionInfo: [AnyHashable: Any]), so flow is working correctly
  1. User open app and after it taps on deeplink :
  • User taps on deeplink:
  • System opens app
  • func didResolveDeepLink(_ result: DeepLinkResult) returns correct data
  1. User has installed the app, but the app is suspended by the system:
  • User taps on deeplink:
  • System opens app
  • func didResolveDeepLink(_ result: DeepLinkResult) doesn't send any events
@andr-ggn
Copy link
Contributor

andr-ggn commented Feb 4, 2021

Are you sure that you have still allocated delegate object?
@property(weak, nonatomic) id<AppsFlyerDeepLinkDelegate> deepLinkDelegate;
SDK does not retain your object. Maybe it released by your app?

@ko7tya
Copy link
Author

ko7tya commented Feb 4, 2021

@andr-ggn
I checked, and delegate object not released

@tomoakley
Copy link

tomoakley commented Mar 31, 2021

Hi, I believe I am also facing this issue. My app is a React Native app, so was using the AppsFlyer RN SDK, but also tried it with this SDK directly and could not resolve the OneLink. I have provided more detail here AppsFlyerSDK/appsflyer-react-native-plugin#223

@amit-kremer93
Copy link
Contributor

@tomoakley The issue in RN SDK is fixed from version 6.2.10

@EmmaVvv
Copy link

EmmaVvv commented Jun 30, 2021

We're also facing the same issue using IOS SDK.
didResolveDeepLink(_ result: DeepLinkResult) not being triggered if the app is suspended by the system.

We would highly appreciate if the issue is fixed as soon as possible

@pepasibble
Copy link

pepasibble commented Oct 26, 2021

I'm also hitting this issue. didResolveDeepLink is called, but only when the Xcode configuration is Debug. When the configuration is Release, didResolveDeepLink is never called.

Edit: this turned out to be due to accidentally registering with the AppsFlyer SDK in both React Native and in Swift code (we have a hybrid app). I guess there was a race condition which ended up always going one way for Debug and the other way for Release. Removing registration from React Native and just doing it in Swift resolved the issue.

@dungntm58
Copy link

Is there any update? I'm using 6.7.0 now and still facing this issue. It only works when I paste universal links into the Chrome search bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants