Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Saved traces include ndarray objects #4810

Closed
Jgilhuly opened this issue Sep 30, 2024 · 0 comments · Fixed by #4838
Closed

[BUG] Saved traces include ndarray objects #4810

Jgilhuly opened this issue Sep 30, 2024 · 0 comments · Fixed by #4838
Assignees
Labels
bug Something isn't working

Comments

@Jgilhuly
Copy link
Contributor

Describe the bug
Traces generated by our Langchain instrumentor and saved via the following code include some ndarray objects:

traces = px.Client().get_trace_dataset(project_name=project_name)
traces.save()

If you then try to load these traces via either the log_traces method or via the --with-trace-fixtures or --with-projects flags, you see the following error:

Error message:
ERROR:phoenix.server.app:Unexpected error processing fixture 'demo_langgraph_agent': Object of type ndarray is not JSON serializable

To Reproduce
Steps to reproduce the behavior:

  1. Trace a LangGraph application (may apply to langchain as well but haven't tested just that) using our LangChainInstrumentor
  2. Save traces using the code above
  3. (Alternatively, use this file for testing: https://storage.googleapis.com/arize-phoenix-assets/traces/langgraph-demo-traces.parquet)
  4. Attempt to load those traces using log_traces() method or one of the phoenix serve flags

Expected behavior
Traces will be loaded into the dashboard and visible.

Environment (please complete the following information):

  • OS: MacOS
  • Notebook Runtime: VSCode
  • Browser: all
  • Phoenix Version: 4.36.0

Additional context
If you load traces by passing them into the launch_app() method instead of log_traces, they will be loaded correctly.

@Jgilhuly Jgilhuly added bug Something isn't working triage issues that need triage labels Sep 30, 2024
@mikeldking mikeldking removed the triage issues that need triage label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants