Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest commit cause compiler crash #25

Closed
MaxGraey opened this issue Feb 9, 2018 · 7 comments
Closed

Latest commit cause compiler crash #25

MaxGraey opened this issue Feb 9, 2018 · 7 comments

Comments

@MaxGraey
Copy link
Member

MaxGraey commented Feb 9, 2018

Latest commit #ad92d91f014a7a7a8dfc2900c9fdccf11d47a43c cause to assertion error:

"AssertionError: assertion failed
    at n.assert (http://localhost:3000/assemblyscript.js:1:227147)
    at t.compile (http://localhost:3000/assemblyscript.js:1:77574)
    at Object.m [as compile] (http://localhost:3000/assemblyscript.js:1:266060)
    ...

in assemblyscript.js bundle

@MaxGraey MaxGraey changed the title Latest commit cause compiler crashing Latest commit cause compiler crash Feb 9, 2018
@dcodeIO
Copy link
Member

dcodeIO commented Feb 9, 2018

Hard to tell from that stack trace. Could you add the source map and trigger it again?

@MaxGraey
Copy link
Member Author

MaxGraey commented Feb 9, 2018

It's little bit hard to do now. I think much easier try to run latest AS build in node.js

@dcodeIO
Copy link
Member

dcodeIO commented Feb 9, 2018

Might also be that you are missing the builtins library file in compilation now that these definitions are parsed instead of being added internally.

If that's the case, then you can provide it to parseFile togther with the source manually, using (lib)/builtins.ts as the file name and isEntry=false.

@MaxGraey
Copy link
Member Author

MaxGraey commented Feb 9, 2018

Hmm, yes may be this cause to problem. But, if we build bundle (especially for browser) I think we should include all files

@dcodeIO
Copy link
Member

dcodeIO commented Feb 9, 2018

Could well be that this is the assertion error you are seeing.

At this point, assemblyscript.js is more like a libassemblyscript, without any convenience features. Ideally, there'd also be a browser-build of asc with a virtual file system underneath that contains all the library components. You can also see asc.js for some insights on how library files are included in compilation.

@MaxGraey
Copy link
Member Author

MaxGraey commented Feb 9, 2018

Okay, I'll think about how to work around for include extra files

@MaxGraey MaxGraey closed this as completed Feb 9, 2018
dcodeIO added a commit that referenced this issue Feb 9, 2018
@dcodeIO
Copy link
Member

dcodeIO commented Feb 9, 2018

willemneal pushed a commit to willemneal/assemblyscript that referenced this issue May 31, 2019
…ecode

Rework encode/decode to support instance decode
radu-matei pushed a commit to radu-matei/assemblyscript that referenced this issue Oct 13, 2020
radu-matei pushed a commit to radu-matei/assemblyscript that referenced this issue Oct 13, 2020
* 'master' of github.com:jedisct1/wasa:
  Fixed the memory leak for Time.sleep (AssemblyScript#33)
  Improve Descriptor (AssemblyScript#25)
  Bump assemblyscript from 0.9.2 to 0.9.4 (AssemblyScript#27)
  Deps
  Optimizations + update dependencies (AssemblyScript#21)
  Bump @as-pect/cli from 2.7.0 to 2.8.1 (AssemblyScript#23)
  Bump assemblyscript from 0.9.1 to 0.9.2 (AssemblyScript#24)
  Fix Date.now to return milliseconds instead of microseconds (AssemblyScript#19)
  Bump assemblyscript from 0.9.0 to 0.9.1 (AssemblyScript#17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants