Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Testsuite (2) #465

Merged
merged 16 commits into from
Feb 24, 2022
Merged

New Testsuite (2) #465

merged 16 commits into from
Feb 24, 2022

Conversation

rs028
Copy link
Collaborator

@rs028 rs028 commented Jan 5, 2022

First tests for the new testsuite (do not run when make tests is executed).

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #465 (a0609b8) into master (afc3896) will increase coverage by 10.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #465       +/-   ##
===========================================
+ Coverage   55.37%   65.54%   +10.16%     
===========================================
  Files          17       17               
  Lines        2046     2046               
===========================================
+ Hits         1133     1341      +208     
+ Misses        913      705      -208     
Flag Coverage Δ
build 52.27% <0.00%> (+0.03%) ⬆️
tests 83.11% <0.00%> (?)
unittests 31.62% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/inputFunctions.f90 55.02% <0.00%> (+18.94%) ⬆️
src/outputFunctions.f90 55.84% <0.00%> (+5.84%) ⬆️
src/parameterModules.f90 92.75% <0.00%> (+1.44%) ⬆️
src/atchem2.f90 87.68% <0.00%> (+2.53%) ⬆️
src/argparse.f90 28.12% <0.00%> (+3.90%) ⬆️
src/dataStructures.f90 58.06% <0.00%> (+8.06%) ⬆️
src/solverFunctions.f90 49.38% <0.00%> (+13.58%) ⬆️
src/constraintFunctions.f90 40.31% <0.00%> (+18.60%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118c485...a0609b8. Read the comment docs.

@rs028
Copy link
Collaborator Author

rs028 commented Feb 17, 2022

While implementing the new tests, I noticed that there are upgraded versions of openlibm and numdiff, so I have included that here.
It seems to fail the tests on mac, but I am not sure if it is a caused by the upgrade or something else).

@rs028 rs028 requested a review from spco February 17, 2022 17:23
@rs028
Copy link
Collaborator Author

rs028 commented Feb 17, 2022

When this is okay, I will merge it and add more tests in a separate PR, as this one already has a lot of changes.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@rs028
Copy link
Collaborator Author

rs028 commented Feb 19, 2022

Now the original behavioural tests are renamed oldtests and the newly developed tests are being added to modeltests. Both sets of tests are running under the CI setup.

Eventually the oldtests will be deleted (if obsolete or redundant) and/or moved to modeltests.

@rs028 rs028 merged commit 782f393 into AtChem:master Feb 24, 2022
@rs028 rs028 deleted the testsuite2 branch September 21, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants