From d84f4a70e818126d8924d7a55d20d0f574d2eb25 Mon Sep 17 00:00:00 2001 From: Ofir Levitan Date: Sun, 2 May 2021 12:08:46 +0300 Subject: [PATCH 1/3] docs(waitFor): add default docs to `waitFor` --- src/retry.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/retry.ts b/src/retry.ts index 118ec71..31ba0f6 100755 --- a/src/retry.ts +++ b/src/retry.ts @@ -96,6 +96,12 @@ export async function retry(action: () => T | Promise, options?: IRetryOpt throw lastError || new Error(`failed after ${attemptCount} tries`); } -export function waitFor(action: () => T | Promise, options?: IRetryOptions): Promise { - return retry(action, { delay: 10, timeout: 1000, retries: Infinity, ...options }); +/** + * @param options defaults to `{delay: 10, timeout: 1000, retries: Infinity }` + */ +export function waitFor( + action: () => T | Promise, + options: IRetryOptions = { delay: 10, timeout: 1000, retries: Infinity } +): Promise { + return retry(action, { ...options }); } From 8dc614955d53afc93a946c2744b796ebd026e0d5 Mon Sep 17 00:00:00 2001 From: Ofir Levitan Date: Sun, 2 May 2021 12:25:01 +0300 Subject: [PATCH 2/3] removed destracturing --- src/retry.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/retry.ts b/src/retry.ts index 31ba0f6..a15bb27 100755 --- a/src/retry.ts +++ b/src/retry.ts @@ -99,9 +99,6 @@ export async function retry(action: () => T | Promise, options?: IRetryOpt /** * @param options defaults to `{delay: 10, timeout: 1000, retries: Infinity }` */ -export function waitFor( - action: () => T | Promise, - options: IRetryOptions = { delay: 10, timeout: 1000, retries: Infinity } -): Promise { - return retry(action, { ...options }); +export function waitFor(action: () => T | Promise, options: IRetryOptions): Promise { + return retry(action, { delay: 10, timeout: 1000, retries: Infinity, ...options }); } From d3437b0979b2e05688caa7fa0226d18388912ea5 Mon Sep 17 00:00:00 2001 From: Ofir Levitan Date: Sun, 2 May 2021 12:26:09 +0300 Subject: [PATCH 3/3] fixes signature --- src/retry.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/retry.ts b/src/retry.ts index a15bb27..3802f58 100755 --- a/src/retry.ts +++ b/src/retry.ts @@ -99,6 +99,6 @@ export async function retry(action: () => T | Promise, options?: IRetryOpt /** * @param options defaults to `{delay: 10, timeout: 1000, retries: Infinity }` */ -export function waitFor(action: () => T | Promise, options: IRetryOptions): Promise { +export function waitFor(action: () => T | Promise, options?: IRetryOptions): Promise { return retry(action, { delay: 10, timeout: 1000, retries: Infinity, ...options }); }