Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a rule that looks for internal domain adresses based on an external file #193

Closed
agoncal opened this issue Feb 22, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request rule upstream

Comments

@agoncal
Copy link
Member

agoncal commented Feb 22, 2024

Today we have a rules that look for IP addresses (using RegExp), localhost, etc. Customers also need to look for internal addresses (eg. htpps://our.domain.ldap, htpps://our.second.domain, htpps://yet.another.domain). Instead of asking our customers to create their own AppCAT rules, it would be nice to create a generic rule that looks for a collection of addresses externalized in a csv/txt file.

@brunoborges
Copy link
Member

@agoncal please work with @kthatipally in implementing this rule.

@kthatipally kthatipally self-assigned this Jul 11, 2024
@agoncal
Copy link
Member Author

agoncal commented Jul 12, 2024

This feature is not possible with Windup. It needs to be developed (as Windup does not use any external file as parameters). Is it worth it developing this feature in WindUp? @kthatipally do you know if this is possible in Kantra ?

@brunoborges
Copy link
Member

We will consider this as a new feature in Kantra.

@brunoborges
Copy link
Member

We have asked upstream to consider this idea: konveyor/enhancements#192

@brunoborges brunoborges added enhancement New feature or request upstream and removed triage labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rule upstream
Projects
None yet
Development

No branches or pull requests

3 participants