Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix future timeout issue #419

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Fix future timeout issue #419

merged 2 commits into from
Jan 3, 2019

Conversation

sjkwak
Copy link
Member

@sjkwak sjkwak commented Jan 2, 2019 •
edited by sabeegrewal
Loading

The change addresses future timeout issue (#413, #411) and dispatch signaling issue (#404).

close #413
close #411
close #404

sabeegrewal
sabeegrewal suggested changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@sabeegrewal sabeegrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

core/src/main/scala/org/apache/spark/eventhubs/client/EventHubsClient.scala Outdated Show resolved Hide resolved
basilhariri
basilhariri approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@basilhariri basilhariri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sjkwak sjkwak added the bug fix label Jan 3, 2019
@sjkwak sjkwak added this to the 2.3.7 milestone Jan 3, 2019
@sjkwak sjkwak merged commit 498746f into Azure:master Jan 3, 2019
@FeFi1989 FeFi1989 mentioned this pull request Apr 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basilhariri basilhariri basilhariri approved these changes

@sabeegrewal sabeegrewal sabeegrewal approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
2.3.7
3 participants
@sjkwak @basilhariri @sabeegrewal