Integer overflow on calcDelay

[bcho]

Opening an issue for the other implementations in the codebase.

For the other cases can you please open issues? We'll let their owners clean them up.

Originally posted by @jhendrixMSFT in #23441 (comment)

Implementations seeing the same overflow bug:

azure-sdk-for-go/sdk/messaging/azeventhubs/internal/utils/retrier.go

Lines 117 to 138 in 2312973

	func calcDelay(o exported.RetryOptions, try int32) time.Duration {
	if try == 0 {
	return 0
	}
	pow := func(number int64, exponent int32) int64 { // pow is nested helper function
	var result int64 = 1
	for n := int32(0); n < exponent; n++ {
	result *= number
	}
	return result
	}
	delay := time.Duration(pow(2, try)-1) * o.RetryDelay
	// Introduce some jitter: [0.0, 1.0) / 2 = [0.0, 0.5) + 0.8 = [0.8, 1.3)
	delay = time.Duration(delay.Seconds() * (rand.Float64()/2 + 0.8) * float64(time.Second)) // NOTE: We want math/rand; not crypto/rand
	if delay > o.MaxRetryDelay {
	delay = o.MaxRetryDelay
	}
	return delay
	}

azure-sdk-for-go/sdk/messaging/azservicebus/internal/utils/retrier.go

Lines 120 to 140 in 2312973

	func calcDelay(o exported.RetryOptions, try int32) time.Duration {
	if try == 0 {
	return 0
	}
	pow := func(number int64, exponent int32) int64 { // pow is nested helper function
	var result int64 = 1
	for n := int32(0); n < exponent; n++ {
	result *= number
	}
	return result
	}
	delay := time.Duration(pow(2, try)-1) * o.RetryDelay
	// Introduce some jitter: [0.0, 1.0) / 2 = [0.0, 0.5) + 0.8 = [0.8, 1.3)
	delay = time.Duration(delay.Seconds() * (rand.Float64()/2 + 0.8) * float64(time.Second)) // NOTE: We want math/rand; not crypto/rand
	if delay > o.MaxRetryDelay {
	delay = o.MaxRetryDelay
	}
	return delay