Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry types package renaming #7079

Closed
dyladan opened this issue Jan 23, 2020 · 11 comments · Fixed by #7998
Closed

OpenTelemetry types package renaming #7079

dyladan opened this issue Jan 23, 2020 · 11 comments · Fixed by #7998
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@dyladan
Copy link

dyladan commented Jan 23, 2020

Hello. I am one of the maintainers of the OpenTelemetry JS project. This is not a bug or a feature request.

The OpenTelemetry JS project is renaming the @opentelemetry/types package to @opentelemetry/api and bringing all API related concerns which used to reside in @opentelemetry/core into the new package. This change is intended to make it so that library vendors can rely on only the @opentelemetry/api package. The change can be viewed here (open-telemetry/opentelemetry-js#727) and motivation for the change can be viewed here (open-telemetry/opentelemetry-js#721).

I see that you currently depend on the types package, which will be deprecated shortly. https://github.com/Azure/azure-sdk-for-js/search?l=JSON&q=%22opentelemetry%2Ftypes%22

Please reach out to myself or @mayurkale22 if you have any questions.

@ramya-rao-a ramya-rao-a added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Jan 23, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] March milestone Jan 23, 2020
@xirzec xirzec modified the milestones: [2020] March, [2020] April Mar 9, 2020
@jongio
Copy link
Member

jongio commented Mar 13, 2020

I get the following when installing @azure/keyvault-secrets

npm WARN deprecated @opentelemetry/types@0.2.0: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js

@mayurkale22
Copy link

We rename the package from @opentelemetry/types to @opentelemetry/api since 0.4.0.

@jongio
Copy link
Member

jongio commented Mar 13, 2020

Are you saying this is resolved and waiting to be deployed? If so, could you ref the PR here?

@mayurkale22
Copy link

@opentelemetry/api is already published to npm. This is the PR: open-telemetry/opentelemetry-js#727

@jongio
Copy link
Member

jongio commented Mar 13, 2020

Correct, My comment was to confirm that we are still referencing types. Need to update to api.

@dyladan
Copy link
Author

dyladan commented Mar 13, 2020

This repo is still referencing types and needs to be updated to reference api. I also suggest that you change your semver scheme from ^x.y.z to either ~x.y.z or lock versions with x.y.z otherwise you may receive breaking changes during updates until we reach stable 1.0.0.

@xirzec
Copy link
Member

xirzec commented Mar 14, 2020

@jongio are you blocked by this? Our plan was to release our final preview with OT beta (eta Mar 16)

@dyladan caret ranges for 0.x.x work differently than after major version 1. Specifically, caret does not allow the left-most non-zero value to change. E.g. ^0.3.0 will not accept 0.4.0 or higher. source: https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004

@jongio
Copy link
Member

jongio commented Mar 14, 2020 via email

@tibor19
Copy link

tibor19 commented Apr 9, 2020

@xirzec @mayurkale22 I am blocked by this change. I am trying to use Azure storage-blob to create a github action, and it fails with this error:
Error: Cannot find module '/home/runner/work/_actions/tibor19/Azure-Storage-Action/node-only/node_modules/@opentelemetry/types/build/src/index.js'. Please verify that the package.json has a valid "main" entry

@xirzec
Copy link
Member

xirzec commented Apr 9, 2020

Error: Cannot find module '/home/runner/work/_actions/tibor19/Azure-Storage-Action/node-only/node_modules/@opentelemetry/types/build/src/index.js'. Please verify that the package.json has a valid "main" entry

This looks like a bundler is expecting an ES module rather than a CJS export? I'm not sure if the new OT package will help if it's not exporting modules.

@xirzec
Copy link
Member

xirzec commented Apr 28, 2020

This work is now live on NPM: https://www.npmjs.com/package/@azure/core-tracing/v/1.0.0-preview.8

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants