Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min/max dependency fixes for core-paging and logger #8479

Closed
sadasant opened this issue Apr 22, 2020 · 9 comments · Fixed by #8648
Closed

Min/max dependency fixes for core-paging and logger #8479

sadasant opened this issue Apr 22, 2020 · 9 comments · Fixed by #8648
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@sadasant
Copy link
Contributor

Karishma found the following issues while trying minimum and maximum supported versions on the KeyVault packages:

2 Errors with core-http 1.0.0 and not core-http 1.1.0

node_modules/@azure/core-http/es/lib/operationOptions.d.ts:2:10 - error TS2459: Module '"../../../core-tracing/types/core-tracing"' declares 'SpanOptions' locally, but it is not exported.
2 import { SpanOptions } from "@azure/core-tracing";
           ~~~~~~~~~~~
  node_modules/@azure/core-tracing/types/core-tracing.d.ts:9:10
    9 import { SpanOptions } from '@opentelemetry/types';
               ~~~~~~~~~~~
    'SpanOptions' is declared here.


node_modules/@azure/core-http/es/lib/webResource.d.ts:9:10 - error TS2459: Module '"../../../core-tracing/types/core-tracing"' declares 'SpanOptions' locally, but it is not exported.
9 import { SpanOptions } from "@azure/core-tracing";
           ~~~~~~~~~~~
  node_modules/@azure/core-tracing/types/core-tracing.d.ts:9:10
    9 import { SpanOptions } from '@opentelemetry/types';
               ~~~~~~~~~~~
    'SpanOptions' is declared here.



4 errors with core-paging 1.1.0 that we don't get with core-paging 1.1.1

list.test.ts:85:29 - error TS2488: Type 'never' must have a '[Symbol.iterator]()' method that returns an iterator. 
85       for (const version of page) {
                               ~~~~

list.test.ts:116:29 - error TS2488: Type 'never' must have a '[Symbol.iterator]()' method that returns an iterator. 
116       for (const version of page) {
                                ~~~~

list.test.ts:168:32 - error TS2488: Type 'never' must have a '[Symbol.iterator]()' method that returns an iterator. 
168       for (const properties of page) {
                                   ~~~~

list.test.ts:229:32 - error TS2488: Type 'never' must have a '[Symbol.iterator]()' method that returns an iterator. 
229       for (const deletedKey of page) {


1 error with logger 1.0.0

../src/log.ts:9:14 - error TS2742: The inferred type of 'logger' cannot be named without a reference to '../test/node_modules/@azure/logger/types/logger'. This is likely not portable. A type annotation is necessary. 
9 export const logger = createClientLogger("keyvault-keys");
               ~~~~~~ 
Found 1 error.
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Apr 22, 2020
@sadasant sadasant self-assigned this Apr 22, 2020
@jeremymeng
Copy link
Member

4 errors with core-paging 1.1.0 that we don't get with core-paging 1.1.1

This is related to my change in PR #7569. We could revert the changes to keyvault code then it should work with both core-paging 1.1.0 and 1.1.1

@ramya-rao-a ramya-rao-a added this to the [2020] May milestone Apr 27, 2020
@sadasant
Copy link
Contributor Author

Thank you Jeremy! That sounds good

@sadasant
Copy link
Contributor Author

sadasant commented May 1, 2020

@ramya-rao-a , @KarishmaGhiya isn't it better to update all of our packages? I'll ping you this Friday.

@ramya-rao-a
Copy link
Contributor

In #7998, all packages in the master branch have been updated to use "@azure/core-http": "^1.1.1", but otherwise yes. If we are making a fix for an issue found in min/max testing, it should be applied across the board.

@sadasant sadasant changed the title [KeyVault] Upgrade to core-http 1.1.0 and upgrade logger Min/max dependency fixes for core-paging and logger May 1, 2020
@sadasant
Copy link
Contributor Author

sadasant commented May 1, 2020

I have changed the title of this issue. I will be making a PR setting core-paging to ^1.1.1 and logger to ^1.0.1 everywhere. I'll follow up with @KarishmaGhiya too.

@yangguang1527
Copy link

May I know when this will be fully fix? as I can install the latest version last week, but now cannot

@ramya-rao-a
Copy link
Contributor

@yangguang-hs Can you elaborate on the issue you are seeing? If you are installing fresh, then you should get the latest version of all the dependencies and this shouldnt be a problem

@KarishmaGhiya
Copy link
Member

@sadasant yes we have to update min dep for all packages

@ramya-rao-a
Copy link
Contributor

Are we planning to log a separate issue to investigate the error with the logger?

../src/log.ts:9:14 - error TS2742: The inferred type of 'logger' cannot be named without a reference to '../test/node_modules/@azure/logger/types/logger'. This is likely not portable. A type annotation is necessary. 
9 export const logger = createClientLogger("keyvault-keys");

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants