Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on additional role assigments and examples #202

Open
baatch opened this issue Oct 21, 2021 · 3 comments
Open

Improve documentation on additional role assigments and examples #202

baatch opened this issue Oct 21, 2021 · 3 comments
Assignees
Labels
backlog Backlog item feature Feature Requests
Milestone

Comments

@baatch
Copy link
Contributor

baatch commented Oct 21, 2021

Describe the solution you'd like

The documentation for adding additional role requirements at https://github.com/Azure/data-management-zone/blob/main/docs/EnterpriseScaleAnalytics-ServicePrincipal.md#adding-additional-role-assigments
could be improved by adding additional text to describe that the role assignments should be done on either resource or resource group level. Also clear examples in the code examples with values makes it easier to follow and understand.

See discussion with marvibuss here #199

@baatch baatch added the feature Feature Requests label Oct 21, 2021
@marvinbuss marvinbuss added the backlog Backlog item label Oct 21, 2021
@marvinbuss
Copy link
Collaborator

@esbran and @amanjeetsingh can you please take a look and discuss how we can improve?
Please also check this to understand the issue: #199

@marvinbuss marvinbuss removed their assignment Oct 22, 2021
@marvinbuss
Copy link
Collaborator

The same must be done from all other repos: Data Landing Zone, Data Product xyz.

@marvinbuss marvinbuss added this to the v1.2.0 milestone Oct 24, 2021
@marvinbuss
Copy link
Collaborator

@kbhatiaGIT was mentioning as well that this is confusing. Can you please update this in the following weeks?

@marvinbuss marvinbuss modified the milestones: v1.2.0, v1.3.0 Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Backlog item feature Feature Requests
Projects
None yet
Development

No branches or pull requests

5 participants