Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize color picker #49

Open
dongskyler opened this issue May 22, 2020 · 3 comments
Open

Modernize color picker #49

dongskyler opened this issue May 22, 2020 · 3 comments
Labels
complexity: 3/5 Complexity 3 out of 5 with 5 being the highest lang: javascript priority: low Low priority tasks status: on hold Issues that are on hold type: enhancement Improve existing features
Milestone

Comments

@dongskyler
Copy link
Member

dongskyler commented May 22, 2020

Use a more modern approach for the color picker.

This will also address #35 Feature request: Auto-fill hex code of color picker.
Issue #35 was addressed by a separate PR.

@dongskyler dongskyler self-assigned this May 22, 2020
@dongskyler dongskyler added complexity: 2/5 Complexity 2 out of 5 with 5 being the highest lang: javascript status: in progress Issues that are being resolved type: enhancement Improve existing features labels May 22, 2020
@dongskyler dongskyler added this to the Version 2.0. Reboot milestone May 22, 2020
@dongskyler dongskyler added complexity: 3/5 Complexity 3 out of 5 with 5 being the highest and removed complexity: 2/5 Complexity 2 out of 5 with 5 being the highest labels May 25, 2020
@dongskyler
Copy link
Member Author

dongskyler commented May 27, 2020

Deemed the following color picker not suitable:
https://github.com/Simonwep/pickr

It can only initialize one instance at a time, and it cannot re-rendered dynamically.

Trying something else.

@dongskyler dongskyler added status: available Issues that are up for grab and removed status: in progress Issues that are being resolved labels May 27, 2020
@dongskyler
Copy link
Member Author

dongskyler commented May 27, 2020

Resolution

I haven't found a good, modern, and suitable JS color picker to replace the current one.

For the time being, the current one will do the job.

I'm going to pause my effort on this issue.

Possible candidates

Summary of unviable color pickers

https://github.com/Simonwep/pickr

  • Cannot initialize multiple color pickers
  • Cannot dynamically re-render an existing color picker

https://github.com/PitPik/tinyColorPicker

  • The last commit was 4 years ago, so I doubt it can dynamically re-render itself (JavaScript itself wasn't ready then)

@dongskyler dongskyler removed their assignment May 27, 2020
@dongskyler dongskyler added status: in progress Issues that are being resolved and removed status: available Issues that are up for grab labels May 27, 2020
@dongskyler dongskyler assigned dongskyler and unassigned dongskyler May 27, 2020
@dongskyler dongskyler added status: available Issues that are up for grab and removed status: in progress Issues that are being resolved labels May 27, 2020
@tangaw
Copy link
Collaborator

tangaw commented May 27, 2020

Sounds good.

@tangaw tangaw modified the milestones: Version 2.0. Reboot, On Deck May 27, 2020
@tangaw tangaw modified the milestones: On Deck, Backlog May 27, 2020
@tangaw tangaw added this to the Backlog milestone May 28, 2020
@dongskyler dongskyler added help wanted Extra attention is needed priority: low Low priority tasks labels May 29, 2020
@dongskyler dongskyler added status: on hold Issues that are on hold and removed status: available Issues that are up for grab help wanted Extra attention is needed labels Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: 3/5 Complexity 3 out of 5 with 5 being the highest lang: javascript priority: low Low priority tasks status: on hold Issues that are on hold type: enhancement Improve existing features
Projects
None yet
Development

No branches or pull requests

2 participants