-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce notebook cleaning and linting scripts with an example #535
Conversation
This looks good to me. One thing we might want to consider is just having @eb8680 , any thoughts? |
I haven't used |
I think it's OK to keep the notebook part separate for now. |
I think this is more about Relatedly, I resolved this in the |
Yes, I think it would be a mistake to have Anyway, who would you like to review this @rfl-urbaniak ? I always find it confusing when there are two reviewers listed. |
Ok, thanks for clarifying. The changes to the notebook have my stamp of approval. @eb8680 , ball's in your court to review the broader PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK to me, thanks for taking this on!
This partially resolves #409 .
Makefile
is modified accordinglytutorial_i
only for now. To pass lint, all imports are moved to the top of the file, and two function names are modified. Other changes are the result of auto-formatting.nbqa
is added to dependencies.What is not covered in this PR:
reason: we need to make sure we agree about these methods first
Once we are on the same page about this, I will add the workflow and work on other notebooks one by one, to cover the same notebooks as the ones tested in
test_notebooks
. This will most likely require manual revisions to notebooks and re-running them completely, so I prefer to do these in separate small PRs.