Fix sleep timers during OS suspend #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some platforms, `tokio::time::sleep` will sleep according to system uptime, not according to the wall clock. This means that for some operations that are time-sensitive, like token refreshes, tasks will sleep for too long when waking up from an OS suspend. To fix this, we introduce `sleep_systime`, which sleeps in small increments, checking wall clock time on wakeup, and otherwise marshalls out directly to `tokio::time::sleep` for short durations as they don't generally cause usability issues.
rsdy
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms,
tokio::time::sleepwill sleep according to system uptime, not according to the wall clock. This means that for some operations that are time-sensitive, like token refreshes, tasks will sleep for too long when waking up from an OS suspend.To fix this, we introduce
sleep_systime, which sleeps in small increments, checking wall clock time on wakeup, and otherwise marshalls out directly totokio::time::sleepfor short durations as they don't generally cause usability issues.Closes BLO-1707