From 55d49eb3ccf36a08fe3521ce1261ec77d1798878 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 21 Sep 2017 16:15:25 -0700 Subject: [PATCH] errors: replace `.split()` with `.replace()` Replace a somewhat idiosyncratic use of `split()` to remove a prefix with `replace()`. (A case could be made for `slice()` as well but I think this is more readable.) PR-URL: https://github.com/nodejs/node/pull/15545 Reviewed-By: Jeremiah Senkpiel Reviewed-By: Colin Ihrig Reviewed-By: Timothy Gu Reviewed-By: Luigi Pinca Reviewed-By: Ruben Bridgewater --- lib/internal/errors.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/internal/errors.js b/lib/internal/errors.js index 59785df7eb67ff..d81a070a110a65 100755 --- a/lib/internal/errors.js +++ b/lib/internal/errors.js @@ -311,7 +311,7 @@ function invalidArgType(name, expected, actual) { let determiner; if (typeof expected === 'string' && expected.startsWith('not ')) { determiner = 'must not be'; - expected = expected.split('not ')[1]; + expected = expected.replace(/^not /, ''); } else { determiner = 'must be'; }