Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate emulation speed management #184

Closed
adriweb opened this issue Feb 15, 2018 · 10 comments
Closed

More accurate emulation speed management #184

adriweb opened this issue Feb 15, 2018 · 10 comments
Assignees
Milestone

Comments

@adriweb
Copy link
Member

adriweb commented Feb 15, 2018

As discussed between @jacobly0 and @runer112.
Basically about frame drops, being too early/late, catching up, etc.

09:01:46 <@runer112> if you're ahead, sleep until next_time
09:01:57 <@runer112> if you're less than 0.1s behind, full speed ahead
09:02:15 <@jacobly> should I go with 100Hz?
09:02:25 <@runer112> if you're more than 0.1s behind, manually pull up cur_time (or pull back next_time?) so the gap is only 0.1s, and then full speed ahead
09:02:52 <@runer112> err
09:02:59 <@jacobly> oh, so only drop a multiple of .1s at a time?
09:03:05 <@runer112> no
09:03:10 <@runer112> drop any excess over 0.1s
09:05:12 <@jacobly> but then we stay stuck at .1s behind?
09:05:33 <@runer112> you shouldn't
09:05:39 <@runer112> if it's behind, it should run unthrottled
09:05:46 <@runer112> it should be able to catch back up
...
10:39:24 <@jacobly> basically the question is should time spent in the debugger be dropped or should we just reset afterwards
10:41:52 <@runer112> I guess ideally, after resuming from something like debugging, you'd set the defecit to 0

@adriweb adriweb added this to the v1.x milestone Feb 15, 2018
@mateoconlechuga
Copy link
Member

I dunno but I probably broke things. I'm not sure where last_time goes.

@mateoconlechuga
Copy link
Member

bump

@mateoconlechuga
Copy link
Member

Well, I broke things but everything still works so I guess it's probably fine then?

@runer112 runer112 modified the milestones: v1.x, v1.1 May 11, 2018
@runer112
Copy link
Member

Mateo has suggested that this outstanding issue is the cause of the bug that can lock up CEmu for a while upon giving it focus if "Pause emulation on focus change" is enabled.

@adriweb
Copy link
Member Author

adriweb commented Jun 3, 2018

This may take a bit more time to analyze and take care of, so we might as well postpone it for a later release, instead of making it block v1.1.
Will be mentioned as a caveat in the release note...

@adriweb adriweb modified the milestones: v1.1, v1.x Jun 3, 2018
@adriweb
Copy link
Member Author

adriweb commented Jun 21, 2018

Setting this as a release blocker and v1.1 again, following a discussion with @runer112:

<Runer112> my [release] veto has been constantly applied because of that bug
<Runer112> it has pretty negative usability implications
<Runer112> probably worse than the sum of all bugs in 1.0, from the perspective of the average user anyway
<Runer112> and from our perspective because everybody who downloads it will be reporting bugs about freezes and stuff

@adriweb adriweb added bug annoyance BLOCKER Release-blocking issue labels Jun 21, 2018
@adriweb adriweb modified the milestones: v1.x, v1.1 Jun 21, 2018
@jacobly0 jacobly0 removed the BLOCKER Release-blocking issue label Jun 22, 2018
@jacobly0
Copy link
Member

The GUI lock up is unrelated to this issue.

@jacobly0 jacobly0 modified the milestones: v1.1, v1.x Jun 22, 2018
@adriweb
Copy link
Member Author

adriweb commented Jan 17, 2019

With the changes from #304, what do we do about this issue?

@mateoconlechuga
Copy link
Member

I wouldn't really call this a "bug" anymore.

@adriweb adriweb removed this from the v2.0 - Source-lvl dbg milestone May 26, 2019
@adriweb adriweb added this to the Any version milestone May 26, 2019
@adriweb
Copy link
Member Author

adriweb commented Jun 26, 2024

Closing this thanks to all the improvements since then, and probably especially the recent ones by @calc84maniac.

@adriweb adriweb closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants