Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timers are off #256

Closed
jacobly0 opened this issue May 25, 2018 · 17 comments
Closed

Timers are off #256

jacobly0 opened this issue May 25, 2018 · 17 comments
Assignees
Milestone

Comments

@jacobly0
Copy link
Member

I think cpu_restore_next can't be called inside port.c -> sched_process_pending_events. Should I move it out or conditionalize it.

@jacobly0 jacobly0 self-assigned this May 25, 2018
@jacobly0 jacobly0 added this to the v1.1 milestone May 25, 2018
@jacobly0
Copy link
Member Author

Here's the latest timer testing program.

@adriweb
Copy link
Member

adriweb commented May 25, 2018

Here's the latest timer testing program.

This manages to crash CEmu, actually :P
Assertion failed: (0 <= delay && delay <= 2), function gpt_next_event, file ../../core/timers.c, line 64.

@mateoconlechuga
Copy link
Member

Move it out :)

@jacobly0
Copy link
Member Author

Fixed the cpu_restore_next issue in 9133e0c, but now graphing triggers the assert reproducibly.

@jacobly0
Copy link
Member Author

Fixed the graphing assert in 376ed58, now back to the original issue.

@jacobly0
Copy link
Member Author

Now enabling a 32K asserts...

@mateoconlechuga
Copy link
Member

branch before it's too late ;)

@jacobly0
Copy link
Member Author

Fixed this assert with cd7afbd and fixed all but one case of the offset timers with 93c4cff, now to just fix that.

@jacobly0
Copy link
Member Author

jacobly0 commented Jun 1, 2018

Fixed a bunch of obscure offset issues in 296fb15, so now I think everything works except lines 0-4.

@adriweb
Copy link
Member

adriweb commented Jun 3, 2018

Nice job!

I've moved to 1.x the two other remaining issues that we originally planned to fix for 1.1, but clearly they'll take some more time to (re)dive into, analyze, and fix.
So I guess when this one is closed (or if you think it's good enough as it is now?), it should be good to release v1.1 :)

@mateoconlechuga
Copy link
Member

Good enough for me :) Let's do a release! :D

@adriweb
Copy link
Member

adriweb commented Jun 9, 2018

Good enough for me :) Let's do a release! :D

I'm just waiting for @jacobly0 to give his green light :P The lang stuff got updated in the meantime.

@adriweb adriweb added the BLOCKER Release-blocking issue label Jun 10, 2018
@adriweb
Copy link
Member

adriweb commented Jun 10, 2018

Fixed the graphing assert in 376ed58, now back to the original issue.

Just had a freeze when trying to graph something, so it looks like a release will have to wait (assuming it's directly related) for this to be fixed at least :(
Repro equation in Y1: fnInt(X,X,0,X)
Edit: simpler repro : "XX" (but X² works...)

@jacobly0
Copy link
Member Author

Fixed graphing freeze with f3c109c.

@jacobly0 jacobly0 removed the BLOCKER Release-blocking issue label Jun 20, 2018
@adriweb
Copy link
Member

adriweb commented Jun 20, 2018

Yep, can confirm :)

@mateoconlechuga
Copy link
Member

CLOSE IT :D

@jacobly0
Copy link
Member Author

#254 was closed a while ago, but this issue is for the few subtle remaining issues, and so won't be closed for some time, and therefore, should not be considered a blocker.

@adriweb adriweb modified the milestones: v1.1, v1.x Jun 21, 2018
@mateoconlechuga mateoconlechuga modified the milestones: v1.x, Any version Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants