Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Page Edit Modal: Add validation to text fields. #90

Closed
2 tasks
shubhanshu02 opened this issue Sep 6, 2021 · 2 comments · Fixed by #92
Closed
2 tasks

Profile Page Edit Modal: Add validation to text fields. #90

shubhanshu02 opened this issue Sep 6, 2021 · 2 comments · Fixed by #92
Assignees
Labels
bug Something isn't working

Comments

@shubhanshu02
Copy link
Member

Currently, in the edit profile modal on the Profile page, the usernames such as “ABC DEF” are allowed while trimming is done only on either end. Due to this, the URLs are changed to something like https://hackalog.copsiitbhu.co.in/profile/ABC%20DEF.

Though everything works fine, this should be avoided when possible.

Tasks

  • Add validation to the username field
  • Add validation to GitHub username field.

Possible Solutions

  1. Show an invalid username warning.
  2. Trim all the whitespaces in the middle of such fields before sending them to the backend
@shubhanshu02 shubhanshu02 added the bug Something isn't working label Sep 6, 2021
@somesh202
Copy link
Member

@shubhanshu02 Can I work on this issue?

@shubhanshu02
Copy link
Member Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants