Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dagger should not depend on Circuit #2

Open
NathanCQC opened this issue Apr 28, 2023 · 2 comments
Open

Dagger should not depend on Circuit #2

NathanCQC opened this issue Apr 28, 2023 · 2 comments

Comments

@NathanCQC
Copy link
Collaborator

NathanCQC commented Apr 28, 2023

Dagger not depend on the self._circuit It should only depend on the _cuquantum_interleaved() method.

This is because once the circuit is post selected by adding caps to the post select qubits. When this network is daggered. It does not know about the caps and returns an un post selected network.

@NathanCQC
Copy link
Collaborator Author

I guess this will be fixed when we migrate to the Network class.

@yapolyak
Copy link
Contributor

yapolyak commented May 6, 2023

I think cuQuantum actually has this functionality now, so we could totally look into adding it. Or we can discuss how to fix this ourselves!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants