Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate potential CMake improvements #1482

Open
jake-arkinstall opened this issue Jul 4, 2024 · 0 comments · May be fixed by #1501
Open

Investigate potential CMake improvements #1482

jake-arkinstall opened this issue Jul 4, 2024 · 0 comments · May be fixed by #1501
Assignees

Comments

@jake-arkinstall
Copy link
Contributor

At the moment, dependant projects need to find and link Eigen3 in order to link tket::tket, because:

  • public-facing headers depend on eigen headers.
  • eigen is linked privately in CMakeLists.txt

Ideally, tket/test/CMakeLists.txt should build by linking only tket and catch2, and having cmake transitively include the dependencies of tket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant