Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor texture packs render incorrectly #2302

Closed
CrafterDaemon opened this issue Feb 1, 2024 · 6 comments
Closed

Armor texture packs render incorrectly #2302

CrafterDaemon opened this issue Feb 1, 2024 · 6 comments
Labels
E-external Closed: External issue

Comments

@CrafterDaemon
Copy link

CrafterDaemon commented Feb 1, 2024

Bug Description

While using Sodium and the Energy Manipulation datapack, I found that the armor renders very poorly for anyone who is using sodium. The bug is purely client-side, as if it (the datapack) is on a server, all players not using sodium render the armor correctly.
prplr
hblehc

Reproduction Steps

Download and Install Sodium
Download and Install a resource pack that modifies armor (attached is the datapack where I encountered the error)
energy-manipulation 0.26.0 - minecraft 1.20.2 to 1.20.4.zip
xylo-s-resource-pack 0.16.0.zip
acquire the retextured armor (Caster armor in the datapack)
Equip and use F5, or put the armor on an armor stand.

Log File

latest.log

Crash Report

crash-2024-01-31_22.32.22-client.txt

@CrafterDaemon CrafterDaemon added the S-needs-triage Status: Needs triage label Feb 1, 2024
@CrafterDaemon
Copy link
Author

Seems to be an Iris issue, but pops up sodium incompatibility in top corner

@CrafterDaemon CrafterDaemon reopened this Feb 1, 2024
@CrafterDaemon
Copy link
Author

reopening just in case

@CrafterDaemon
Copy link
Author

Tested with another texture pack that changes chestplates to have gloves, no issues.
image

@CrafterDaemon
Copy link
Author

only happens with shaders enabled
Shader effects do not matter afaik

@MeeniMc
Copy link
Contributor

MeeniMc commented Feb 1, 2024

you have a lot of moving parts here, you need to simplify the problem. ETF, 3D-skin layer, Iris, etc may be the root cause.

Try again with only Sodium, and only the resource pack of interest. If that works, do dichotomic search to find which mod breaks it.

@coderbot16
Copy link
Contributor

Not a Sodium bug, it's triggered by Iris but it's not fixable. IrisShaders/Iris#1042

See the official Iris documentation: https://github.com/IrisShaders/Iris/blob/1.18.2/docs/development/compatibility/core-shaders.md

Core shaders are not supported by Mojang and servers modify them at their own risk. Iris and Sodium each break different parts of them because they simply can't coexist well with advanced rendering mods.

@pajicadvance pajicadvance added E-external Closed: External issue and removed S-needs-triage Status: Needs triage labels Feb 1, 2024
@pajicadvance pajicadvance closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-external Closed: External issue
Development

No branches or pull requests

4 participants