Fractional pickup index

[marcbelmont]

MORAN_v2/models/fracPickup.py

Line 24 in be56705

if idx <= 0 or idx >= x_shape[3]-1:

Shouldn't it be:
if idx <= 0 or idx >= x_shape[3]:

[marcbelmont]

Have you tried picking idx using the maximum of x instead of randomly?

Is fractional pickup also used at inference time? Wouldn't the random nature of the function be a problem?

[Canjie-Luo]

Emm, you are right. It's a bug. But I guess the "EOS" is near the x_shape[3] and your change may not bring improvement.
Actually, the fractional pickup is only used in the training. Thanks.