[pull] master from MusicPlayerDaemon:master #16
Conversation
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
pull
bot
added
⤵️ pull
and removed
🔍 Ready for Review
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestNo commonly committed files found with a 40% threashold Committed file ranks(click to expand)97.83%[src/input/plugins/CdioParanoiaInputPlugin.cxx] 99.81%[python/build/libs.py] 0.00%[src/io/UniqueFileDescriptor.hxx] 62.78%[src/net/IPv4Address.hxx] 0.00%[subprojects/flac.wrap] 45.32%[src/util/DynamicFifoBuffer.hxx] 26.00%[src/lib/curl/Global.hxx] 0.00%[src/lib/zlib/Error.hxx] 26.00%[src/net/Resolver.hxx] 26.00%[src/util/Cast.hxx] |
|
Hello @pull[bot]! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-03-15 17:46:08 UTC |
According to the yajl API documentation, #include lines should have
the "yajl/" path prefix, but the actual pkg-config file contains:
includedir=${dollar}{prefix}/include/yajl
.. which already contains this directory name, and thus the "yajl/"
prefix cannot work. Unfortunately, the yajl project hasn't been
maintained for nearly 10 years, and there's little chance this bug
will ever be fixed.
The Brew package of yajl is broken, it fails to build:
In file included from ../src/lib/yajl/Handle.cxx:4:
In file included from ../src/lib/yajl/Handle.hxx:6:
/opt/homebrew/Cellar/yajl/2.1.0/include/yajl/yajl_parse.h:22:10: fatal error: 'yajl/yajl_common.h' file not found
#include <yajl/yajl_common.h>
^~~~~~~~~~~~~~~~~~~~
1 error generated.
Therefore, MPD cannot support building with yajl on macOS.
There were a few macOS related bug reports on the bug tracker which have been open for years without a volunteer caring for them. The GitHub actions build has also been broken for a long time due to bugs in the ancient LLVM toolchain shipped with macOS, making macOS an unsuitable non-Linux target for testing MPD's portability. All of this makes macOS support an annoying liability for me. To avoid more frustration, I'm hereby dropping macOS support completely from MPD. Maybe this causes enough pain for a new maintainer to spawn, but maybe nobody cares, so... let's see.
All Linux distributions have at least version 4, and thus I cannot test with older versions.
Fixes crash bug (assertion failure) if a new "play" command is handled while the player thread waits for decoder startup.
This simplifies the lifetime of the nfs_context object.
Another lifetime simplification.
Prints all available stickertypes like tagtypes for tags.
Previously, `AND` expressions were the only filters which used `++s` instead
of `s = StripLeft(s + 1)` making them sensitive to spacing issues. This caused
nested AND expressions (like e.g. `(((A) AND (B)) AND (C))`) to needlessly be
rejected with the following error message: `{find} Word expected` due to the
fact that the inner AND expression would leave the cursor `s` at a space rather
than the beginning of the next word (remainder was ` AND (C))` rather than
`AND (C)`).
This commit fixes this by consistently using `s = StripLeft(s + 1)` instead
of `++s` when parsing AND expressions. Although it is not strictly necessary
to resolve the AND nesting bug, the case of trivial AND expressions (consisting
basically of only superfluous parentheses) is also changed to the new handling.
This should be more robust although I expect that case to be even less common
than the direct nesting of AND expressions.
see #2100
I pretend to know what I'm doing :-)
The the Duplicate() method we inherited from class FileDescriptor returns a UniqueFileDescriptor, but we really want to return a UniqueSocketDescriptor.
-1 is an illegal value and leads to CURLM_BAD_FUNCTION_ARGUMENT. Our API shouldn't imply this value.
Enforce type-safety.
Only relevant on Windows where socket_error_t is a `DWORD` (unsigned).
The bug is still present in GCC 14.
Old: searchplaylist {NAME} {FILTER} [{START:END}]
New: searchplaylist {NAME} {FILTER} [window {START:END}]
This is more similar to the other search commands and we can reuse search specific functions in libmpdclient.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )