Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shelljs instead of rimraf and similar libraries #270

Open
czerwinskilukasz1 opened this issue Jun 27, 2020 · 3 comments
Open

Use shelljs instead of rimraf and similar libraries #270

czerwinskilukasz1 opened this issue Jun 27, 2020 · 3 comments
Labels
CI/TDD/DevOps enhancement New feature or request

Comments

@czerwinskilukasz1
Copy link
Collaborator

In this script rimraf library is used.
It's a library with one functionality only: running rm -rf, hence its name rimraf.

What I propose is instead of such small one-purpose-only libraries use shelljs.
shelljs is already used in our repo and:

  • shelljs is more universal (rimraf is a separate library just for... rm -rf)
  • shelljs has 4x more stars on Github
  • shelljs has 7x... less dependencies (only 19 deps compared to rimraf's whooping 117 deps)
@czerwinskilukasz1 czerwinskilukasz1 added enhancement New feature or request CI/TDD/DevOps discussion A discussion is taking place, please don't work on it yet labels Jun 27, 2020
@mhagmajer
Copy link
Contributor

Like it 🙌

@mhagmajer
Copy link
Contributor

These are the benefits of monorepo that its so much easier to learn 💪

@czerwinskilukasz1
Copy link
Collaborator Author

Cool, removing 'discussion' label then. This issue becomes an action point.

@czerwinskilukasz1 czerwinskilukasz1 removed the discussion A discussion is taking place, please don't work on it yet label Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/TDD/DevOps enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants