Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use AskScript for test args .args.ts and expected result .result.ts #306

Open
mhagmajer opened this issue Jul 1, 2020 · 4 comments
Labels
CI/TDD/DevOps discussion A discussion is taking place, please don't work on it yet
Milestone

Comments

@mhagmajer
Copy link
Contributor

Following discussion in #293, how about we use AskScript to define individual test arguments and results?

@mhagmajer mhagmajer added this to the v1.4 milestone Jul 1, 2020
@czerwinskilukasz1 czerwinskilukasz1 added CI/TDD/DevOps discussion A discussion is taking place, please don't work on it yet labels Jul 3, 2020
@czerwinskilukasz1
Copy link
Collaborator

What would be the gain of rewriting all TypeScript to AskScript for args and results?

@mhagmajer
Copy link
Contributor Author

It would be an easy and fast way to triple the number of ASK files tested in unit testing

@czerwinskilukasz1
Copy link
Collaborator

Wait, args and results are the input and output, not the test.
Also, bear in mind that quantity != quality. These files would be mostly homogeneous, just storing one or two ints or strings, so we couldn't say we have 3 times as many [good] tests.

@czerwinskilukasz1
Copy link
Collaborator

I am also thinking whether they are cases where it's much easier to define the expected output in TypeScript rather than AskScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/TDD/DevOps discussion A discussion is taking place, please don't work on it yet
Projects
None yet
Development

No branches or pull requests

2 participants