Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int[] syntax sugar for array(int) constructor #51

Open
mhagmajer opened this issue Jun 4, 2020 · 14 comments
Open

int[] syntax sugar for array(int) constructor #51

mhagmajer opened this issue Jun 4, 2020 · 14 comments
Labels
AskScript ./src/askscript/** enhancement New feature or request first-timers-only good first issue Good for newcomers help wanted Extra attention is needed type:syntax related to syntax or syntax sugar
Milestone

Comments

@mhagmajer
Copy link
Collaborator

mhagmajer commented Jun 4, 2020

The purpose of this feature request is to support the same syntax sugar that TypeScript has for Array type definition which is T[]. When user writes T[] in type position in AskScript, the parser should interpreter it as array(T) where T like int

Dear new contributor,

If you have any questions on how to start, please write a comment with a tag: @czerwinskilukasz1 or @mhagmajer, or join our Discord Community and let us know there. We will be very happy to help you start! :)

Cheers,
Łukasz (@czerwinskilukasz1)
AskQL Core Developer

@mhagmajer mhagmajer added enhancement New feature or request good first issue Good for newcomers AskScript ./src/askscript/** labels Jun 4, 2020
@Tuhaj
Copy link
Contributor

Tuhaj commented Jun 9, 2020

We need to add here more description, it is hard to find out the scope of the task and not clear where to begin @mhagmajer

@czerwinskilukasz1
Copy link
Collaborator

The scope of this task is to adapt the pegjs parser to accept the new 'int[]' syntax in addition to the current one.
As for the details of the syntax change proposal, we need to ask for Marcin's explanation and examples.

@ghost
Copy link

ghost commented Jun 10, 2020

yes

@mhagmajer
Copy link
Collaborator Author

This purpose of this feature request is to support the same syntax sugar that TypeScript has for Array<T> type definition which is T[]. When user writes T[] in type position in AskScript, the parser should interpreter it as array(T) where T like int

@Fifciu
Copy link
Contributor

Fifciu commented Jun 22, 2020

I could take care of that. I understand it is Peg.js related - I browsed code. However, I need some tips and methods to test it well.

@mhagmajer
Copy link
Collaborator Author

@czerwinskilukasz1 can you help here?

@Fifciu
Copy link
Contributor

Fifciu commented Jun 23, 2020

I am taking it

@czerwinskilukasz1
Copy link
Collaborator

Great, congrats, Filip :)
Feel free to ask questions here or contact with us on our Discord channel.

@czerwinskilukasz1
Copy link
Collaborator

Filip, by the way, didn't you want to work on #52 instead? ;) @Fifciu

@Fifciu
Copy link
Contributor

Fifciu commented Jun 23, 2020

Nope. However, as both are about synthetic sugar - maybe it will be my next step :)

image

@czerwinskilukasz1
Copy link
Collaborator

Cool :)

@czerwinskilukasz1 czerwinskilukasz1 added the type:syntax related to syntax or syntax sugar label Jul 3, 2020
@Fifciu Fifciu removed their assignment Jul 4, 2020
@Tuhaj
Copy link
Contributor

Tuhaj commented Jul 4, 2020

Taking over!

@czerwinskilukasz1
Copy link
Collaborator

Cool, @Tuhaj

@czerwinskilukasz1 czerwinskilukasz1 added help wanted Extra attention is needed P2 first-timers-only and removed P2 labels Jul 8, 2020
@czerwinskilukasz1 czerwinskilukasz1 added this to the v1.4 milestone Jul 9, 2020
@czerwinskilukasz1
Copy link
Collaborator

@Tuhaj , it's been a couple of weeks since you were assigned. Any thoughts or progress on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AskScript ./src/askscript/** enhancement New feature or request first-timers-only good first issue Good for newcomers help wanted Extra attention is needed type:syntax related to syntax or syntax sugar
Projects
None yet
Development

No branches or pull requests

4 participants