Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate performance if CALDB files are used directly #5

Open
hamogu opened this issue Jan 29, 2015 · 1 comment
Open

Investigate performance if CALDB files are used directly #5

hamogu opened this issue Jan 29, 2015 · 1 comment

Comments

@hamogu
Copy link
Member

hamogu commented Jan 29, 2015

JD wanted MARX to be fully self-contained, but as the required calibration files grow, that might not be practical any longer. Files in /data/caldb are taken from CALDB directly or with minimal processing (re-order, bin-up). If at least those files could be read from CALDB (which will be installed on essentially every MARX user's system) directly, I would not have to maintain them.
On the other hand, the performance of MARX will go down and any change in the CALDB format would require an immediate MARX release. Also, accessing CALDB through the normal access routines is potentially a rabbit-hole of complex logic and more dependencies.

Using CALDB directly would mitigate #4 automatically.

To address this issue, I should first do some experiments and measure the performance hit from using the big contam file in CALDB. That much can be tested with no code change.

@hamogu
Copy link
Member Author

hamogu commented Dec 3, 2015

Speed tests on melkor indicate that the performance impact is < 10%. Need to test machines with less RAM, though.

@hamogu hamogu added this to the 5.3 milestone Dec 3, 2015
@hamogu hamogu modified the milestones: 5.4, 5.3 Apr 7, 2016
@hamogu hamogu modified the milestones: 6.0, 5.4 Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant