Improve error message in marxasp #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, marxasp issues an error prompting the user to re-run the simulation with DitherModel=INTERNAL, when run a simulation that used an ASPSOL input file. However, that's not what the typical user wants: If the simulation was run with a real ASPSOL file, then that file should be used. It's still true that marxasp should issue an error (since it won't generate anything), but the message is more helpful now. fixes Chandra-MARX#53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, marxasp issues an error prompting the user to re-run the simulation
with DitherModel=INTERNAL, when run a simulation that used an ASPSOL input file.
However, that's not what the typical user wants:
If the simulation was run with a real ASPSOL file, then that file should be used.
It's still true that marxasp should issue an error (since it won't generate anything),
but the message is more helpful now.
fixes #53